> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Friday, February 26, 2010 3:34 AM > To: Govindarajan, Sriramakrishnan > Cc: linux-omap@xxxxxxxxxxxxxxx; Gole, Anant > Subject: Re: [PATCH 2/2] can:ti_hecc: board specific hookup on AM3517EVM > > * Sriramakrishnan <srk@xxxxxx> [100222 22:35]: > > Add board specific hookup for TI HECC driver on > > AM3517 EVM > > > > Signed-off-by: Sriramakrishnan <srk@xxxxxx> > > Acked-by: Anant Gole <anantgole@xxxxxx> > > --- > > The driver requires that CAN_STB signal be driven low to enable > > CAN PHY. Currently this is being managed from U-boot. Will submit a > patch > > for handling this as part of board init sequence. > > > > arch/arm/mach-omap2/board-am3517evm.c | 38 > +++++++++++++++++++++++++++++ > > arch/arm/mach-omap2/include/mach/am35xx.h | 10 +++++++ > > 2 files changed, 48 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach- > omap2/board-am3517evm.c > > index af99faf..42013b5 100644 > > --- a/arch/arm/mach-omap2/board-am3517evm.c > > +++ b/arch/arm/mach-omap2/board-am3517evm.c > > @@ -20,6 +20,7 @@ > > #include <linux/init.h> > > #include <linux/platform_device.h> > > #include <linux/gpio.h> > > +#include <linux/can/platform/ti_hecc.h> > > --- snip ---- > > + > > +static struct ti_hecc_platform_data am3517_evm_hecc_pdata = { > > + .scc_hecc_offset = AM35XX_HECC_SCC_HECC_OFFSET, > > + .scc_ram_offset = AM35XX_HECC_SCC_RAM_OFFSET, > > + .hecc_ram_offset = AM35XX_HECC_RAM_OFFSET, > > + .mbx_offset = AM35XX_HECC_MBOX_OFFSET, > > + .int_line = AM35XX_HECC_INT_LINE, > > + .version = AM35XX_HECC_VERSION, > > +}; > > The formatting above should use tabs instead of spaces. Please > check and run checkpatch.pl --strict on this. > > Also, sounds like the Kconfig changes should be 2/2, not 1/2 > to enable this. > > Tony > [Sriram] Tony, I did verify the patch with checkpatch(log below) but Somehow, it didn't flag any formatting errors. I realize that there are spaces that need to be converted to tabs. I will re-generate the patch and also re-order the patches as pointed out. $scripts/checkpatch.pl --strict 2-2-can-ti_hecc-board-specific-hookup-on-AM3517EVM.patch total: 0 errors, 0 warnings, 0 checks, 70 lines checked 2-2-can-ti_hecc-board-specific-hookup-on-AM3517EVM.patch has no obvious style problems and is ready for submission. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
