Re: [PATCH] musb: fix power field to hold all possible values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Felipe Balbi <me@xxxxxxxxxxxxxxx> [100223 12:30]:
> Hi,
> 
> On Tue, Feb 23, 2010 at 08:01:50PM +0530, Gupta, Ajay Kumar wrote:
> > Board files are providing the actual mA and it is getting divided in 
> > Arch/arm/mach-omap2/usb-musb.c. See the code snippet below,
> > 
> >         musb_plat.clock = "ick";
> >         musb_plat.board_data = board_data;
> > -->     musb_plat.power = board_data->power >> 1;
> >         musb_plat.mode = board_data->mode;
> > 
> > So we need to either take this patch or fix this logic of dividing the mA
> > supplied from all omap board files.
> 
> that's true, had missed that. Sorry.

Hmm, I believe this value is also divided somewhere else but
I forgot where. In any case, when making changes like this
please run the standard USB tests for gadgets and OTG.

Otherwise things are guaranteed to break for USB certs :)

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux