Manjunath, From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- owner@xxxxxxxxxxxxxxx] On Behalf Of G, Manjunath Kondaiah Sent: Thursday, February 11, 2010 5:35 AM > From: linux-omap-owner@xxxxxxxxxxxxxxx > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Y, Kishore > Sent: Thursday, February 11, 2010 3:33 PM <snip> > > + > > +static void zoom_lcd_tv_panel_init(void) > > +{ > > + int ret; > > + unsigned char lcd_panel_reset_gpio; > > + > > + if (omap_rev() > OMAP3430_REV_ES3_0) { > > + /* Production Zoom2 board: > > + * GPIO-96 is the LCD_RESET_GPIO > > + */ > > + lcd_panel_reset_gpio = LCD_PANEL_RESET_GPIO_PROD; > > + } else { > > + /* Pilot Zoom2 board: > > + * GPIO-55 is the LCD_RESET_GPIO > > + */ > > + lcd_panel_reset_gpio = LCD_PANEL_RESET_GPIO_PILOT; > > + } > > How about: > > lcd_panel_reset_gpio = (omap_rev() > OMAP3430_REV_ES3_0) ? > LCD_PANEL_RESET_GPIO_PROD : > LCD_PANEL_RESET_GPIO_PILOT; This approach has been discussed many times before, and found incorrect. There is no way to auto-detect valid GPIO for reset as of now. For example: Zoom Pilot + 3630 SOM case will fail here. I'll push again for my thoughts on this one... There MUST be a configurable option in kernel menuconfig to select the board revision (Pilot, pre-production). That is the only clean way I can see this could actually work. Regards, Sergio <snip> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
