Re: [alsa-devel] [PATCHv4 0/7] TWL6030 audio codec initial support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-02-24 at 18:17 -0600, Olaya, Margarita wrote:
> 
> > -----Original Message-----
> > From: Liam Girdwood [mailto:lrg@xxxxxxxxxxxxxxx]
> > Sent: Wednesday, February 24, 2010 5:40 AM
> > To: Olaya, Margarita
> > Cc: alsa-devel@xxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCHv4 0/7] TWL6030 audio codec initial support
> > 
> > On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> > > Following patch series add initial support for TWL6030 codec driver.
> > > The patch set is based on the series sent from Misael Lopez in October 2009.
> > >
> > > Changes from v3:
> > > - Remove snd_soc_init_card function
> > > - Adapt to latest twl core changes based on Balaji's comment
> > >
> > > Regards,
> > > Margarita
> > >
> > > ---
> > > Misael Lopez Cruz (7):
> > >   OMAP4: PMIC: Add support for twl6030 codec
> > >   ASoC: TWL6030: Add twl6030 codec driver
> > >   ASoC: TWL6030: Manual power-up/down sequences
> > >   ASoC: TWL6030: Add support for low-power PLL
> > >   ASoC: TWL6030: Add restrictions for low-power playback mode
> > >   ASoC: TWL6030: Enable audio interrupt
> > >   ASoC: TWL6030: Detect power-up sequence completion
> > 
> > Btw, since this is a new driver can you rebase the 6 codec patches into
> > a single patch.
> > 
> 
> The second patch adds the basic support for the codec and the others add features, that way it could be easier to review.

Some of the subsequent patches are actually removing chunks of code
rather than just adding new features. In this case it's actually easier
to review the complete codec driver as one patch rather than a series of
changes (showing your internal development history).

Thanks

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux