RE: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Omar,

> >
> > +#if defined(CONFIG_ARCH_OMAP2420) /* IVA */
> >   err_iva1:
> > -	omap_mbox_unregister(&mbox_dsp_info);
> > +	if (cpu_is_omap2420())
> > +		omap_mbox_unregister(&mbox_dsp_info);
> > +#endif
> 
> why not moving omap_mbox_unregister to the block containing the ifdefs?
> at least you won't be adding an ifdef and if(cpu_xx)

Thanks Omar for the comment. I have received multiple comments on this new #ifdef. So, have sent out a new cleaner patch removing this.

Regards
Suman
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux