> From: Aguirre, Sergio
> Sent: Tuesday, February 23, 2010 7:28 AM
> To: Menon, Nishanth; Gopinath, Thara
[...]
> >
> > >
> > > Signed-off-by: Thara Gopinath <thara@xxxxxx>
> > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
> > > ---
> > > arch/arm/mach-omap2/resource34xx.c | 4 +++-
> > > 1 files changed, 3 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-
> > omap2/resource34xx.c
> > > index 3604a38..d2336d8 100644
> > > --- a/arch/arm/mach-omap2/resource34xx.c
> > > +++ b/arch/arm/mach-omap2/resource34xx.c
> > > @@ -463,6 +463,7 @@ int set_opp(struct shared_resource *resp, u32
> > target_level)
> > > } else if (resp == vdd2_resp) {
> > > unsigned long req_l3_freq;
> > > struct omap_opp *oppx = NULL;
> > > + u8 opp;
> > >
> > > /* Convert the tput in KiB/s to Bus frequency in MHz */
> > > req_l3_freq = (target_level * 1000)/4;
> > > @@ -478,10 +479,11 @@ int set_opp(struct shared_resource *resp, u32
> > target_level)
> > > /* uh uh.. no OPPs?? */
> > > BUG_ON(IS_ERR(oppx));
> > >
> > If you do target_level = 0; here, the entire patch is a oneliner :)
>
> Actually, IMHO will be even more clean, to standardize all OPP value
> passing to be u8.
>
> Do you really need to be prepared for 2^32 opp values? ;)
>
Using OPP ID has to be completely removed from resource34xx.c -> this action is still pending. In this case, using u8 OR initing the target_level to 0 has the same impact. Why add code that will be removed later on anyways?
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
