> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Anna, > Suman > Sent: Friday, February 19, 2010 2:37 AM > To: linux-omap@xxxxxxxxxxxxxxx > Cc: Hiroshi.DOYU@xxxxxxxxx; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > Subject: [PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic > > From 18beb1784db07e4eb2b9d10783a309b5caccb979 Mon Sep 17 00:00:00 2001 > From: Suman Anna <s-anna@xxxxxx> > Date: Fri, 5 Feb 2010 17:20:26 -0600 > Subject: [PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic > > OMAP4 mailbox has a different MAILBOX_SYSCONFIG register. > There is now no AutoIdle. The SIDLEMODE bits have been > right-shifted by 1 bit and now occupy bits 2 & 3. > > Signed-off-by: Suman Anna <s-anna@xxxxxx> > --- > arch/arm/mach-omap2/mailbox.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c > index 88e9043..e0c1f1b 100644 > --- a/arch/arm/mach-omap2/mailbox.c > +++ b/arch/arm/mach-omap2/mailbox.c > @@ -41,6 +41,8 @@ > #define SOFTRESET (1 << 1) > #define SMARTIDLE (2 << 3) > #define OMAP4_SOFTRESET (1 << 0) > +#define OMAP4_NOIDLE (1 << 2) > +#define OMAP4_SMARTIDLE (2 << 2) > > /* SYSSTATUS: register bit definition */ > #define RESETDONE (1 << 0) > @@ -131,7 +133,10 @@ static int omap2_mbox_startup(struct omap_mbox *mbox) > l = mbox_read_reg(MAILBOX_REVISION); > pr_info("omap mailbox rev %d.%d\n", (l & 0xf0) >> 4, (l & 0x0f)); > > - l = SMARTIDLE | AUTOIDLE; > + if (cpu_is_omap44xx()) IP revision check again if possible > + l = OMAP4_SMARTIDLE; > + else > + l = SMARTIDLE | AUTOIDLE; > mbox_write_reg(l, MAILBOX_SYSCONFIG); > > omap2_mbox_enable_irq(mbox, IRQ_RX); > -- > 1.6.6.2 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html