<snip>
> >
> >> Also, keep in mind that the buffers for transfers must begin and end on
> >> a word boundary. The OMAP's DMA controller can only transfer whole
> >> words to the MMC FIFO.
>
> I've slightly modified your patch "mmc: omap_hsmmc: use packet sync'd DMA"
> and it
> seems to work now, at least with SD card and libertas_sdio:
>
Mike,
As per the latest discussion, David replied that this patch is not needed
and FRAME sync just works fine. So, without this patch does SDIO int
functionality work for you?
Regards,
Madhu
> ---
> drivers/mmc/host/omap_hsmmc.c | 23 ++++++++---------------
> 1 files changed, 8 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 4b23225..5408bcb 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -114,6 +114,7 @@
>
> #define MMC_TIMEOUT_MS 20
> #define OMAP_MMC_MASTER_CLOCK 96000000
> +#define OMAP_HSMMC_FIFO_WORDS (512/4)
> #define DRIVER_NAME "mmci-omap-hs"
>
> /* Timeouts for entering power saving states on inactivity, msec */
> @@ -884,24 +885,24 @@ static void omap_hsmmc_config_dma_params(struct
> omap_hsmmc_host *host,
> {
> int blksz, nblk, dma_ch;
>
> + blksz = host->data->blksz;
> + nblk = sg_dma_len(sgl) / blksz;
> +
> dma_ch = host->dma_ch;
> if (data->flags & MMC_DATA_WRITE) {
> omap_set_dma_dest_params(dma_ch, 0, OMAP_DMA_AMODE_CONSTANT,
> - (host->mapbase + OMAP_HSMMC_DATA), 0, 0);
> + (host->mapbase + OMAP_HSMMC_DATA), 0, blksz / 4);
> omap_set_dma_src_params(dma_ch, 0, OMAP_DMA_AMODE_POST_INC,
> sg_dma_address(sgl), 0, 0);
> } else {
> omap_set_dma_src_params(dma_ch, 0, OMAP_DMA_AMODE_CONSTANT,
> - (host->mapbase + OMAP_HSMMC_DATA), 0, 0);
> + (host->mapbase + OMAP_HSMMC_DATA), 0, blksz / 4);
> omap_set_dma_dest_params(dma_ch, 0, OMAP_DMA_AMODE_POST_INC,
> sg_dma_address(sgl), 0, 0);
> }
>
> - blksz = host->data->blksz;
> - nblk = sg_dma_len(sgl) / blksz;
> -
> omap_set_dma_transfer_params(dma_ch, OMAP_DMA_DATA_TYPE_S32,
> - blksz / 4, nblk, OMAP_DMA_SYNC_FRAME,
> + blksz / 4, nblk, OMAP_DMA_SYNC_PACKET,
> omap_hsmmc_get_dma_sync_dev(host, data),
> !(data->flags & MMC_DATA_WRITE));
>
> @@ -944,17 +945,9 @@ static void omap_hsmmc_dma_cb(int lch, u16 ch_status,
> void *data)
> static int omap_hsmmc_start_dma_transfer(struct omap_hsmmc_host *host,
> struct mmc_request *req)
> {
> - int dma_ch = 0, ret = 0, err = 1, i;
> + int dma_ch = 0, ret = 0, err = 1;
> struct mmc_data *data = req->data;
>
> - /* Sanity check: all the SG entries must be aligned by block size.
> */
> - for (i = 0; i < data->sg_len; i++) {
> - struct scatterlist *sgl;
> -
> - sgl = data->sg + i;
> - if (sgl->length % data->blksz)
> - return -EINVAL;
> - }
> if ((data->blksz % 4) != 0)
> /* REVISIT: The MMC buffer increments only when MSB is
> written.
> * Return error for blksz which is non multiple of four.
> --
> 1.6.4.4
>
>
>
> >> David
> >
> >
>
>
> --
> Sincerely yours,
> Mike.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
