On Thu, 18 Feb 2010 15:56:03 +0200 Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> wrote: > > Are you sure about these ids? Same comment to the patch 2 as well. > > Worth to check. > > They are correct. > mcbsp->id is 1 based (1 -> McBSP1, 2 -> McBSP2, etc) > While the exported functions expect the id to > be 0 based (0 -> McBSP1, 1 -> McBSP2, etc) > > But, yes it is confusing at times... > Definitely. As existing API is using 0 based indexing, it's better to use here as well. That would make the lines like below simpler too :-) + return omap_st_set_chgain((id)-1, val, 0, channel); -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
