On Wed, 17 Feb 2010 16:45:58 +0200 Ilkka Koskinen <ilkka.koskinen@xxxxxxxxx> wrote: > The first patch implements McBSP sidetone feature on OMAP3 while the second one > provides ALSA interface for using it. > Do I have something wrong since I cannot adjust the controls? Both "McBSP2 Sidetone Channel [0|1]" show 50%. I used line wrapped diff below. -- Jarkko diff --git a/sound/soc/omap/omap3beagle.c b/sound/soc/omap/omap3beagle.c index d88ad5c..ac4f287 100644 --- a/sound/soc/omap/omap3beagle.c +++ b/sound/soc/omap/omap3beagle.c @@ -84,6 +84,11 @@ static int omap3beagle_hw_params(struct snd_pcm_substream *substream, return 0; } +static int omap3beagle_init(struct snd_soc_codec *codec) +{ + return omap_mcbsp_st_add_controls(codec, 2); +} + static struct snd_soc_ops omap3beagle_ops = { .hw_params = omap3beagle_hw_params, }; @@ -95,6 +100,7 @@ static struct snd_soc_dai_link omap3beagle_dai = { .cpu_dai = &omap_mcbsp_dai[0], .codec_dai = &twl4030_dai[TWL4030_DAI_HIFI], .ops = &omap3beagle_ops, + .init = omap3beagle_init, }; /* Audio machine driver */ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html