Thanks Paul, I am just summarizing all my responses in this email. <snip> > -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Wednesday, February 17, 2010 4:51 AM > To: Shilimkar, Santosh > Cc: tony@xxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; ben@xxxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; > lrg@xxxxxxxxxxxxxxx; Nayak, Rajendra; Syed, Rafiuddin; Ben Dooks > Subject: Re: [PATCH 16/24] omap4: Add i2c support on omap4 platform > > Hello Santosh, > > one general comment on this patch, before the specific comments. Rather > than adding more cpu_is_omap*() all over, please instead convert this code > to use flags passed in via platform_data. The I2C hwmod conversion > patches are one attempt to do that via the hwmod mechanism; you can use > that as an example of one way to do that with this driver. 1. As you suggested most of the driver clock related modifications can be avoided with dummy_nodes. Will do that. 2. Some drivers like gptimer, the clock node names chosen are different between omap4 and rest of the omaps. Since we do clk_get based on clk names, such cases, we need cpu check. Another way is to keep same clock nodes which means need to change database scripts. Which one you prefer ? 3. I shall the possibility of passing flags via board-files instead of cpu_is_xxxx() checks in drivers. This is ofcourse much cleaner approach if it's doable. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
