RE: [PATCH 24/24] omap4: multi-omap: Allow build to work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Tony Lindgren [mailto:tony@xxxxxxxxxxx]
> Sent: Wednesday, February 17, 2010 12:24 AM
> To: Shilimkar, Santosh
> Cc: linux-omap@xxxxxxxxxxxxxxx; ben@xxxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; lrg@xxxxxxxxxxxxxxx;
> paul@xxxxxxxxx
> Subject: Re: [PATCH 24/24] omap4: multi-omap: Allow build to work
> 
> * Santosh Shilimkar <santosh.shilimkar@xxxxxx> [100216 07:55]:
> > The musb support is enable to omap3 platforms. For omap4 only board
> > support is available and the driver still isn't supported.
> > Because of this build with omap3_defconfig used for multi-omap
> > doesn't work on omap4430 sdp.
> >
> > This patch hacks the musb probe to keep the multi-omap build
> > working on omap4430 sdp
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> > ---
> >  drivers/usb/musb/musb_core.c |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> > index bcce8e8..13b1c4a 100644
> > --- a/drivers/usb/musb/musb_core.c
> > +++ b/drivers/usb/musb/musb_core.c
> > @@ -2124,6 +2124,10 @@ static int __init musb_probe(struct platform_device *pdev)
> >  	struct resource	*iomem;
> >  	void __iomem	*base;
> >
> > +	/* FIXME: multi-omap build to work on omap4 */
> > +	if (cpu_is_omap44xx())
> > +		return 0;
> > +
> >  	iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >  	if (!iomem || irq == 0)
> >  		return -ENODEV;
> 
> Should the comment here be "FIXME: allow multi-omap to boot until
> musb is updated for omap4" instead?
yeah
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux