> From: Chitriki Rudramuni, Deepak > Sent: Thursday, February 11, 2010 2:30 AM > > Removed NTFY_Notify() in WMD_MSG_Get() to avoid locking contention > as NTFY_Notify() is already invoked in InputMsg(). > > Cc: Ameya Palande <ameya.palande@xxxxxxxxx> > Cc: Omar Ramirez Luna <omar.ramirez@xxxxxx> > Cc: Nishanth Menon <nm@xxxxxx> > > Signed-off-by: Deepak Chitriki <deepak.chitriki@xxxxxx> > > Ref: > v0:http://marc.info/?l=linux-omap&m=126584779011493&w=2 > v1:Comment fixes from v0 Please move the Ref into the diff stat section (below --- In the next line). > --- > drivers/dsp/bridge/wmd/msg_sm.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/drivers/dsp/bridge/wmd/msg_sm.c > b/drivers/dsp/bridge/wmd/msg_sm.c > index 3a275f1..7de3705 100644 > --- a/drivers/dsp/bridge/wmd/msg_sm.c > +++ b/drivers/dsp/bridge/wmd/msg_sm.c > @@ -296,8 +296,6 @@ DSP_STATUS WMD_MSG_Get(struct MSG_QUEUE *hMsgQueue, > if (LST_IsEmpty(hMsgQueue->msgUsedList)) > SYNC_ResetEvent(hMsgQueue->hSyncEvent); > else { > - NTFY_Notify(hMsgQueue->hNtfy, > - DSP_NODEMESSAGEREADY); > SYNC_SetEvent(hMsgQueue->hSyncEvent); > } > One line code does not need {} - please remove it as well. > @@ -348,8 +346,6 @@ DSP_STATUS WMD_MSG_Get(struct MSG_QUEUE *hMsgQueue, > hMsgQueue->refCount--; > /* Reset the event if there are still queued messages */ > if (!LST_IsEmpty(hMsgQueue->msgUsedList)) { > - NTFY_Notify(hMsgQueue->hNtfy, > - DSP_NODEMESSAGEREADY); > SYNC_SetEvent(hMsgQueue->hSyncEvent); > } One line code does not need {} - please remove it as well. > /* Exit critical section */ > -- > 1.6.3.3 Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
