On Mon, Feb 08, 2010 at 06:38:57PM +0530, Vimal Singh wrote: > In this version: (as per comments recieved for 2nd version) > - remove 'omap_set_vpp' function > - set 'set_vpp' to null Ah, I'm sorry for not being quite exact. "leave set_vpp set to NULL" means there is no need to asign anything to that structure member, because BSS is zeroed (set to NULL) anyway. Something like this: static struct physmap_flash_data sdp_nor_data = { .width = 2, }; Yes, this is a nitpick only... -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html