Hi Omar,
________________________________________
From: ext Omar Ramirez Luna [omar.ramirez@xxxxxx]
Sent: Saturday, February 06, 2010 3:58 AM
To: Palande Ameya (Nokia-D/Helsinki)
Cc: linux-omap@xxxxxxxxxxxxxxx; Menon, Nishanth; Chitriki Rudramuni, Deepak
Subject: Re: [PATCH 2/3] DSPBRIDGE: Get rid of MEM_Free()
On 2/4/2010 9:33 AM, Ameya Palande wrote:
> kfree() is NULL and ZERO pointer safe so MEM_Free() doesn't provide any
> significant advantage. By getting rid of MEM_Free() and the NULL pointer
> check associated with it, we can save on:
> 1. One level of indirection which translates to a function call cost.
> 2. NULL pointer checking cost.
>
> Signed-off-by: Ameya Palande<ameya.palande@xxxxxxxxx>
> ---
> arch/arm/plat-omap/include/dspbridge/mem.h | 19 +------
> drivers/dsp/bridge/gen/gs.c | 4 +-
> drivers/dsp/bridge/pmgr/cmm.c | 12 ++--
> drivers/dsp/bridge/pmgr/cod.c | 4 +-
> drivers/dsp/bridge/pmgr/dbll.c | 15 ++---
> drivers/dsp/bridge/pmgr/dev.c | 9 +--
> drivers/dsp/bridge/pmgr/wcd.c | 46 ++++++---------
> drivers/dsp/bridge/rmgr/dbdcd.c | 13 ++---
> drivers/dsp/bridge/rmgr/disp.c | 3 +-
> drivers/dsp/bridge/rmgr/drv.c | 38 +++++-------
> drivers/dsp/bridge/rmgr/drv_interface.c | 2 +-
> drivers/dsp/bridge/rmgr/nldr.c | 52 ++++++-----------
> drivers/dsp/bridge/rmgr/node.c | 87 ++++++++++------------------
> drivers/dsp/bridge/rmgr/proc.c | 10 +--
> drivers/dsp/bridge/rmgr/rmm.c | 19 +++---
> drivers/dsp/bridge/rmgr/strm.c | 3 +-
> drivers/dsp/bridge/services/mem.c | 17 ------
> drivers/dsp/bridge/services/ntfy.c | 7 +-
> drivers/dsp/bridge/services/regsup.c | 10 ++--
> drivers/dsp/bridge/services/sync.c | 3 +-
> drivers/dsp/bridge/wmd/chnl_sm.c | 11 ++--
> drivers/dsp/bridge/wmd/io_sm.c | 12 ++--
> drivers/dsp/bridge/wmd/msg_sm.c | 8 +-
> drivers/dsp/bridge/wmd/tiomap3430.c | 17 ++----
> drivers/dsp/bridge/wmd/ue_deh.c | 6 +-
> 25 files changed, 157 insertions(+), 270 deletions(-)
>
Acked-by: Omar Ramirez Luna <omar.ramirez@xxxxxx>
I had to rework the patch as it sits on top of changes adding 3 more
MEM_Free lines.
drv.c
@@ -603,10 +603,10 @@ DSP_STATUS DRV_Create(OUT struct DRV_OBJECT
**phDRVObject)
pDRVObject);
*phDRVObject = pDRVObject;
} else {
- MEM_Free(pDRVObject->devList);
- MEM_Free(pDRVObject->devNodeString);
+ kfree(pDRVObject->devList);
+ kfree(pDRVObject->devNodeString);
proc.c
@@ -409,7 +409,7 @@ DSP_STATUS PROC_AutoStart(struct CFG_DEVNODE *hDevNode,
"No Exec file found \n");
}
func_cont:
- MEM_Free(hProcObject->g_pszLastCoff);
+ kfree(hProcObject->g_pszLastCoff);
hProcObject->g_pszLastCoff = NULL;
MEM_FreeObject(hProcObject);
func_end:
If no objection I'll be pushing tomorrow.
No problem :)
Cheers,
Ameya.--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
