> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, February 05, 2010 3:19 AM > To: Premi, Sanjeev > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/3] twl4030: keypad: Hooks for board > specific suspend-resume > > Sanjeev Premi <premi@xxxxxx> writes: > > > This patch adds hooks to support board specific > > implementation during the suspend and resume operations. > > > > The TWL4030 can be connected to multiple boards. Without > > these hooks, board specific macros will be required in a > > generic driver. > > > > Signed-off-by: Sanjeev Premi <premi@xxxxxx> > > Looks ok, but I think you should drop the 'on_' prefix in function > pointer names. > > Kevin > Will re-submit this patch after change. ~sanjeev [snip]--[snip] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html