"Govindraj.R" <govindraj.raja@xxxxxx> writes: [...] >>> >> + * @baud: baudrate for which divisor needs to be calculated. >>> >> + * >>> >> + * We have written our own function to get the divisor so as to support >>> >> + * 13x mode. >>> >> + */ >>> > >>> > Again, the why, not the how. Why do you need the 13x divisor? What's >>> > magic about 3Mbaud? >>> > >>> >>> Refering to TRM UART chapter 17: >>> >>> Table 17-1. UART Mode Baud Rates, Divisor Values, and Error Rates >>> >>> referring to oversampling - divisor value >>> >>> baudrate 460,800 to 3,686,400 all have divisor 13 >>> >>> except 3,000,000 which has divisor value 16 >>> >>> thus we are checking if baud != 3000000 >> >> Ok. It's always useful to have just a bit of information in the driver >> so you don't have to search around the manual when trying to figure out >> why something was done. >> >> Maybe something simple: "3Mbaud is unique in that it requires a divisor >> of 13. See the TRM for full details". > > ok. will add that comments. Referncing TRM Chapter and Section names (and/or numbers) is very helpful too. Usually section names are more helpful since numbers change w/TRM versions. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
