Re: [PATCH] DSPBRIDGE: Get rid of driver_minor global variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nishanth,

On Mon, 2010-02-01 at 20:48 +0100, ext Menon, Nishanth wrote:
> Ameya Palande said the following on 02/01/2010 08:18 PM:
> > Since there is only 1 device there is no need of driver_minor global variable.
> i am a little skeptical about this change - mainly coz, it might be a good idea for a userspace option
> to be able to define what the minor id could be -> maybe an example could be /dev/mem which has a minor
> id of 1, not 0. having a module_param might be better as such.. just my 2 cents..

I do not agree with user space having control of defining minor id.
I would like to rephrase this sentence as: userspace should have control
of defining name (string) for the device file. I guess udev takes care
of that already!
 
Ideally userspace should just deal with device
names: /dev/device1, /dev/device2 etc. Why it interprets (and that way
creates a dependency on) major/minor number?

I am in favor of saving 4 bytes and less global namespace pollution :)

/dev/mem has minor id of 1 because it shares its major id with ramdisk.

file: include/linux/major.h

#define MEM_MAJOR               1
#define RAMDISK_MAJOR           1

Cheers,
Ameya.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux