RE: [PATCH] DSPBRIDGE: Various compile warning fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 

>-----Original Message-----
>From: Palande Ameya (Nokia-D/Helsinki) 
>Sent: 25 January, 2010 19:03
>To: ext Omar Ramirez Luna
>Cc: linux-omap@xxxxxxxxxxxxxxx; Menon, Nishanth; Chitriki 
>Rudramuni, Deepak; Kukkonen Mika (Nokia-D/Helsinki)
>Subject: RE: [PATCH] DSPBRIDGE: Various compile warning fixes
>
>Hi Omar,
>
>Sorry for the top posthing :(
>I guess the original patch had empty if() bodies. 
>That comment can be removed :)

No, the empty if() bodies fix is the chunk that modifies
those macros:

>> -#define DBC_Assert(exp)
>> -#define DBC_Require(exp)
>> -#define DBC_Ensure(exp)
>> +#define DBC_Assert(exp) {}
>> +#define DBC_Require(exp) {}
>> +#define DBC_Ensure(exp) {}
(...)
>> -#define DBG_Exit(void)
>> +#define DBG_Exit(void) do {} while (0)

etc. Those are used in code as

if (whatever)
   do_stuff();
else
   DBC_Assert(exp);
do_something_else();

and you really want to DBC_Assert() not to be totally
empty, but instead evaluate to an empty statement block.

--MiKu--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux