"Gopinath, Thara" <thara@xxxxxx> writes: >>>-----Original Message----- >>>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>>Sent: Saturday, January 23, 2010 6:12 AM >>>To: Gopinath, Thara >>>Cc: linux-omap@xxxxxxxxxxxxxxx >>>Subject: Re: [PATCH 8/8] OMAP3 PM: Support to enable disable OSWR feature from pm debug fs >>> >>>Thara Gopinath <thara@xxxxxx> writes: >>> >>>> This patch adds enable_oswr flag in pm debug fs to enable >>>> disable OSWR feature. >>>> To enable this feature: >>>> echo 1 > <path>/debug/pm_debug/enable_oswr >>>> To disable this feature >>>> echo 0 > <path>/debug/pm_debug/enable_oswr >>>> >>>> Signed-off-by: Thara Gopinath <thara@xxxxxx> >>> >>>I don't like this approach since it leads to incorrect CPUidle statistics. >>> >>>Sanjeev has proposed a different approach[1] (which I still need to >>>review/merge) which just invalidates particular CPUidle states and >>>then lets the CPUidle enter hook only pick a valid state. >>> >>>This then will work for the enable_off_mode support and the enable_oswr support >>>as well as anything else we can dream up down the road. > > Hi Kevin, > > Yes I agree with you.. I did not implement this for OSWR as I did > not see it in you pm branch. I thought let the first set of patches > for OSWR be merged in and then when we change enable_off_mode we can > change enable_oswr also. Is there an issue with this? I would rather merge Sanjeev's patch first. I just reviewed it and asked him for a few minor fixes and then I'd like to merge it. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
