Re: [PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 1/21/2010 7:03 AM, Ameya Palande wrote:
Signed-off-by: Ameya Palande<ameya.palande@xxxxxxxxx>
---
  drivers/dsp/bridge/rmgr/proc.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c
index a75b64a..91ab64f 100644
--- a/drivers/dsp/bridge/rmgr/proc.c
+++ b/drivers/dsp/bridge/rmgr/proc.c
@@ -512,6 +512,10 @@ DSP_STATUS PROC_AutoStart(struct CFG_DEVNODE *hDevNode,
  			 "No Exec file found \n");
  	}
  func_cont:
+	if (hProcObject->g_pszLastCoff) {
+		MEM_Free(hProcObject->g_pszLastCoff);
+		hProcObject->g_pszLastCoff = NULL;
+	}

Wouldn't be better to keep this inside PROC_Load in case of error?

Also MEM_Free checks for NULL.

  	MEM_FreeObject(hProcObject);
  func_end:
  	GT_1trace(PROC_DebugMask, GT_ENTER,

Regards,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux