On Thu, Jan 21, 2010 at 3:40 PM, Ameya Palande <ameya.palande@xxxxxxxxx> wrote:
> --- a/drivers/dsp/bridge/wmd/io_sm.c
> +++ b/drivers/dsp/bridge/wmd/io_sm.c
> @@ -1210,7 +1210,7 @@ static void InputChnl(struct IO_MGR *pIOMgr, struct CHNL_OBJECT *pChnl,
> pChnlMgr->uWordSize;
> chnlId = IO_GetValue(pIOMgr->hWmdContext, struct SHM, sm, inputId);
> dwArg = IO_GetLong(pIOMgr->hWmdContext, struct SHM, sm, arg);
> - if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) {
> + if (chnlId >= CHNL_MAXCHANNELS) {
Could chnlld be less than zero? Anyway better to test:
(chnlId >= CHNL_MAXCHANNELS || chnlld < 0)
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
