Eduardo Valentin wrote: > On Wed, Jan 20, 2010 at 12:14:59PM +0100, ext Romit Dasgupta wrote: >>> From: Eduardo Valentin <eduardo.valentin@xxxxxxxxx> >>> >>> OMAP OPP layer functions now have dependencies of CONFIG_CPU_FREQ only. >>> >>> With this patch, omap opp layer now has its compilation flags >>> bound to CONFIG_CPU_FREQ. Also its code has been removed from pm34xx.c. >>> >>> A new file has been created to contain cpu freq code related to >>> OMAP3: cpufreq34xx.c. >>> >>> Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxx> >> NAK also for the following non-working kernel (smartreflex without cpufreq). > > Then this is a problem of dependency with smartreflex and cpufreq. In this case > better to solve this other problem with another patch. This patch is to rip off > cpufreq code from pm34xx, as stated in the above description. In that case the right fix should 1) __not__ include opp.h for non cpufreq builds OR 2) If it includes opp.h the functions for getting current opp should abstract out the right mechanism to get current frequency/voltage from the chip/power IC. > > And sorry, I didn't get your boot log (if you intended to put it, as you said > "following non-working kernel" > Actually I meant for the following non-working kernel __configuration__. I do not have boot logs! -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
