:) Thanks.. > -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Wednesday, January 20, 2010 11:15 AM > To: G.N, Vijayakumar > Cc: Turquette, Mike; Kauppi Ari (EXT-Ixonos/Oulu); linux-omap@xxxxxxxxxxxxxxx; > khilman@xxxxxxxxxxxxxxxxxxx; Sripathy, Vishwanath > Subject: RE: [PATCHV2 2/2] OMAP3630: Clock: Fixing HSDivider Limitation > > Hello Vijayakumar, > > On Wed, 20 Jan 2010, G.N, Vijayakumar wrote: > > > This seems to better than which currently I have; I will incorporate and > > test it for the same. I will add few more comments to have a better > > clarity in the same function. > > That's fine but please keep in mind this section from CodingStyle: > > -------- > > Generally, you want your comments to tell WHAT your code does, not HOW. > Also, try to avoid putting comments inside a function body: if the > function is so complex that you need to separately comment parts of it, > you should probably go back to chapter 6 for a while. You can make > small comments to note or warn about something particularly clever (or > ugly), but try to avoid excess. Instead, put the comments at the head > of the function, telling people what it does, and possibly WHY it does > it. > > -------- > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
