Hi Alan, > > please comment on following patch. > > Why move them out - why not just make them const ? There's 2 options: 1) we only make them const now. And we move them out later when we do the conversion to the generic watchdog api (which means that we will rip out the code for the open, release, write and ioctl handling of /dev/watchdog) or 2) we make them const and move them out of ioctl and then the ripping out of the code is much easier. I opted for the second option. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html