(cc'ing Ranjith) Hi Alexander, On Fri, 15 Jan 2010, Alexander Shishkin wrote: > On Fri, Jan 15, 2010 at 02:07:04 -0700, Paul Walmsley wrote: > > Split the DPLL3 M2 divider clock functions out of clock34xx.c and move them > > into clkt3xxx_dpll3m2.c to improve maintainability. > > I'm not very familiar with maintainability issues of dpll3m2, so > forgive me if it is ignorant for me to ask you to elaborate on this. That is a very good point, those original patch changelogs are pretty crappy. "OMAP clock code - same great taste, now with more maintainability!" I will update them and repost with more detail. > It does look like a bit of an overkill to have a separate file for > a divider. But again, I might well be missing the point. Yep, this is definitely a borderline case where it might be more appropriate to keep it in the clock34xx.c file. What ultimately motivated splitting it out was the thought that the AM3517/3505 chips probably won't need this function, since I don't believe they support DVFS [1], so we could skip compiling this function for kernels built for those devices via the Makefile, and not need #ifdefs. Ranjith, could you correct me if I am wrong about the DVFS part? regards, - Paul 1. AM35x ARM Microprocessor Technical Reference Manual, http://www.ti.com/litv/pdf/sprugr0 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
