Re: [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Jan 2010 10:05:12 +0200
Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> wrote:

> > What about introducing this simplification in a separate followup patch,
> > quoting your rationale in its changelog? I can try to prepare one if you
> > agree.
> 
> I think it is OK to have a followup patch addressing these.
> Just mention in a comment, that you are writing the cached value back to the 
> register, which does not have these status flags set, thus clearing the reason 
> in McBSP.
> 
> Jarkko: What do you think?
> 
I agree, follow-up patch sound cleaner and safer than modifying the
patch 4.

-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux