>> Returning NULL pointer from the OPP APIs instead of ERR_PTR where >> return struct omap_opp *. This is because there is no inherent value in >> returning ERR_PTR from the opp layer. Returning NULL serves the purpose. >NAK. >Using ERR_PTR allows returning different types of error conditions, >and is common practice across the kernel. Yes, it is true that it is a common practice but in case of the OPP layer I did not see any purpose. The caller of the APIs returning struct omap_opp * can just check for NULL value for failure.-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html