On Thu, 2010-01-14 at 21:37 +0100, ext Grazvydas Ignotas wrote: > On Thu, Jan 14, 2010 at 4:05 PM, Tomi Valkeinen > <tomi.valkeinen@xxxxxxxxx> wrote: > > On Wed, 2010-01-13 at 22:01 +0100, ext Grazvydas Ignotas wrote: > >> On Wed, Jan 13, 2010 at 5:02 PM, Tomi Valkeinen > >> <tomi.valkeinen@xxxxxxxxx> wrote: > >> > Hi, > >> > > >> > This doesn't apply, can you resend based on Linus' tree or my DSS2 tree? > >> > >> ok, will resend shortly. > >> > >> BTW, what about enabling vdds_dsi/vdds_sdi regulators we talked about > >> earlier? This patch already sets up those regulators in the board file > >> for DSS2 to get and enable them. I can come up with a patch for that > >> if you want (perhaps doing it somewhere in dss_init()). > > > > It would be nice to get this clarified from TI's HW side, but I haven't > > had time to do that. > > > > However, it sure looks like your theory is correct, so a patch would be > > ok. > > > > I don't think dss_init is a proper place for it. The power only needs to > > be enabled when the display is on, so perhaps > > dpi_display_enable/disable() would be better place to turn it on and off > > (and suspend/resume). Below is a quick patch I made to test this. > > > > But is the same code needed by RFBI and SDI also? And is it needed only > > when certain pins are in use? And only on OMAP3. I'm not sure what would > > be the most elegant way for this, but perhaps for now it's good enough > > if we enable the power in dpi.c's enable/disable. > > I can only test this on pandora (24bit parallel display), and your > patch works fine there. Ok, good to know. I'm not very happy with the patch yet, but something like it is needed. > Gražvydas > > PS: I see some author names got mangled in your GIT (got prefixed with 'ext'). Argh. It's the notorious Nokia mailserver. Thanks for pointing it out. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
