Re: [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Anuj Aggarwal wrote:
> Makefile is modified so that board-omap35x-twl4030-pmic.c gets compiled
> for the platforms having TWL4030 as the PMIC.
> 
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@xxxxxx>
> ---
>  arch/arm/mach-omap2/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Can you combine this patch with "Modifying Kconfig to choose from the
available PMICs" patch?
Moreover, I think the patches should be reordered so that kernel build
won't be broken. Maybe something like:
1 - Creating TWL4030 specific file having supplies & init data
2 - Modifying Kconfig and Makefile to choose from the available PMICs
3 - Kconfig modified to select TWL4030 for OMAP3 based platforms
4 - Use common regulator supplies and init data structs

> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index b32678b..181be39 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -107,6 +107,7 @@ obj-$(CONFIG_MACH_IGEP0020)		+= board-igep0020.o \
>  					   mmc-twl4030.o
>  obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK)	+= board-omap3touchbook.o \
>  					   mmc-twl4030.o
> +obj-$(CONFIG_PMIC_TWL4030)		+= board-omap35x-twl4030-pmic.o
>  obj-$(CONFIG_MACH_OMAP_4430SDP)		+= board-4430sdp.o
>  
>  obj-$(CONFIG_MACH_OMAP3517EVM)     += board-am3517evm.o


-- 
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux