>From: Menon, Nishanth
>
>Omar Ramirez Luna had written, on 01/07/2010 07:00 PM, the following:
>> This patch removes an unused variable in bridge_open
>> and bridge_release functions, which reduces indentation.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxx>
>> ---
>> drivers/dsp/bridge/rmgr/drv_interface.c | 25 +++++--------------------
>> 1 files changed, 5 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c
>> index 3a4d058..e551840 100644
>> --- a/drivers/dsp/bridge/rmgr/drv_interface.c
>> +++ b/drivers/dsp/bridge/rmgr/drv_interface.c
>> @@ -540,18 +540,10 @@ static void __exit bridge_exit(void)
>> static int bridge_open(struct inode *ip, struct file *filp)
>> {
>> int status = 0;
>> - DSP_STATUS dsp_status;
>> - HANDLE hDrvObject;
>> struct PROCESS_CONTEXT *pr_ctxt = NULL;
>>
>> GT_0trace(driverTrace, GT_ENTER, "-> bridge_open\n");
>>
>> - dsp_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
>> - if (DSP_FAILED(dsp_status)) {
>is this some sort of verification if the hDrvObject is valid?
>if so this is not an unused variable rt?
No, this drv object was used for inserting and removing the process
context, it doesn't work as validation at least not in this place.
>
>> - status = -EIO;
>> - goto err;
>> - }
>> -
>> /*
>> * Allocate a new process context and insert it into global
>> * process context list.
>> @@ -564,7 +556,6 @@ static int bridge_open(struct inode *ip, struct file *filp)
>>
>> filp->private_data = pr_ctxt;
>>
>> -err:
>> GT_0trace(driverTrace, GT_ENTER, "<- bridge_open\n");
>> return status;
>> }
>> @@ -576,8 +567,6 @@ err:
>> static int bridge_release(struct inode *ip, struct file *filp)
>> {
>> int status = 0;
>> - DSP_STATUS dsp_status;
>> - HANDLE hDrvObject;
>> struct PROCESS_CONTEXT *pr_ctxt;
>>
>> GT_0trace(driverTrace, GT_ENTER, "-> bridge_release\n");
>> @@ -588,15 +577,11 @@ static int bridge_release(struct inode *ip, struct file *filp)
>> }
>>
>> pr_ctxt = filp->private_data;
>> - dsp_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
>> - if (DSP_SUCCEEDED(dsp_status)) {
>is this some sort of verification if the hDrvObject is valid?
>if so this is not an unused variable rt?
No, this drv object was used for inserting and removing the process
context, it doesn't work as validation at least not in this place.
>> - flush_signals(current);
>> - DRV_RemoveAllResources(pr_ctxt);
>> - PROC_Detach(pr_ctxt);
>> - MEM_Free(pr_ctxt);
>> - } else {
>> - status = -EIO;
>> - }
>> + flush_signals(current);
>> + DRV_RemoveAllResources(pr_ctxt);
>> + PROC_Detach(pr_ctxt);
>> + MEM_Free(pr_ctxt);
>> +
>> filp->private_data = NULL;
>>
>> err:
>
- omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
