Current implementation of identifying silicon revision uses whole number returned by omap_rev() - which includes cpu id and class as well. As new silicons are added in 35x, 36x and 44x series, many 'greater than' comparisons are automatically true; but 'less than/ equal to' comparisons are no always right. Also, there could be a problem when revisions of newer silicons arrive. This patch uses only revision bits to identify silicon revision - independent of silicon being used. This version came after long period as i was trying ways to include the verbose cpuid in either function name or signature. But final outcome was bit messy and aborting it (for now). [1] http://marc.info/?l=linux-omap&m=125476176410106&w=2 [2] http://marc.info/?l=linux-omap&m=125197467922935&w=2 Sanjeev Premi (1): omap3: Add macros for comparing si revision arch/arm/mach-omap2/clock34xx.c | 2 +- arch/arm/mach-omap2/clock34xx_data.c | 6 ++- arch/arm/mach-omap2/control.c | 7 ++-- arch/arm/mach-omap2/id.c | 13 +++---- arch/arm/mach-omap2/pm34xx.c | 35 ++++++++++++++++----- arch/arm/plat-omap/include/plat/cpu.h | 55 +++++++++++++++++++++++++++++++++ 6 files changed, 97 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
