"Hiremath, Vaibhav" <hvaibhav@xxxxxx> writes: >> -----Original Message----- >> From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >> Sent: Thursday, January 07, 2010 5:20 AM >> To: Hiremath, Vaibhav >> Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; Govindarajan, >> Sriramakrishnan >> Subject: Re: [PATCH 2/3] AM35xx: Introduce am35xx.h file >> >> hvaibhav@xxxxxx writes: >> >> > From: Vaibhav Hiremath <hvaibhav@xxxxxx> >> > >> > Add base address definations for new AM35xx IPSS modules, like >> > VPFE, USBOTG, CPGMAC. >> > >> > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> >> > Signed-off-by: Sriramakrishnan <srk@xxxxxx> >> > --- >> > arch/arm/plat-omap/include/plat/am35xx.h | 25 >> +++++++++++++++++++++++++ >> > arch/arm/plat-omap/include/plat/hardware.h | 1 + >> > 2 files changed, 26 insertions(+), 0 deletions(-) >> > create mode 100644 arch/arm/plat-omap/include/plat/am35xx.h >> > >> > diff --git a/arch/arm/plat-omap/include/plat/am35xx.h >> b/arch/arm/plat-omap/include/plat/am35xx.h >> > new file mode 100644 >> > index 0000000..d41bd61 >> > --- /dev/null >> > +++ b/arch/arm/plat-omap/include/plat/am35xx.h >> > @@ -0,0 +1,25 @@ >> > +/*: >> > + * Address mappings and base address for AM35XX specific >> interconnects >> > + * and peripherals. >> > + * >> > + * Copyright (C) 2009 Texas Instruments >> > + * >> > + * Author: Sriramakrishnan <srk@xxxxxx> >> > + * Vaibhav Hiremath <hvaibhav@xxxxxx> >> > + * >> > + * This program is free software; you can redistribute it and/or >> modify >> > + * it under the terms of the GNU General Public License version 2 >> as >> > + * published by the Free Software Foundation. >> > + */ >> > +#ifndef __ASM_ARCH_AM35XX_H >> > +#define __ASM_ARCH_AM35XX_H >> > + >> > +/* >> > + * Base addresses >> > + */ >> > +#define AM35XX_IPSS_EMAC_BASE 0x5C000000 >> > +#define AM35XX_IPSS_USBOTGSS_BASE 0x5C040000 >> > +#define AM35XX_IPSS_HECC_BASE 0x5C050000 >> > +#define AM35XX_IPSS_VPFE_BASE 0x5C060000 >> >> I think this secont needs ome more comments. In the 34xx TRM memory >> map, this region is shown as IVA2, so folks familiar with 34xx might >> be confused. >> > [Hiremath, Vaibhav] I will update the comment with sufficient info. > >> That being said, is there any reason to have these in a global >> header >> file? Nobody should use these except SoC/board init code, so these >> should probably stay in arch/arm/mach-omap2 in AM35x specific code. >> > [Hiremath, Vaibhav] Agreed, but there are some occurrences where these macros may required to use in plat-omap/ directory. Just for an example - > > Macro OMAP443X_SCM_BASE, defined in > arch/arm/plat-omap/include/plat/omap44xx.h file is getting used in > arch/arm/plat-omap/common.c file. OK, but SCM_BASE has nothing to do with the base addresses you're adding in this patch. My point is that I don't see a need for the values in this patch to be defined in a global header. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
