Hi, > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Felipe Balbi > Sent: Monday, December 28, 2009 4:40 PM > To: Tony Lindgren > Cc: Linux OMAP Mailing List; Felipe Balbi > Subject: [PATCH 7/8] arm: omap: musb: pass board mode to usb_musb_init > > each board will have a different mode which is peculiar > to that board. > > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > --- <snip> > > #include <mach/hardware.h> > #include <asm/mach-types.h> > @@ -203,7 +204,7 @@ static void __init omap_2430sdp_init(void) > platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices)); > omap_serial_init(); > twl4030_mmc_init(mmc); > - usb_musb_init(100); > + usb_musb_init(MUSB_OTG, 100); Similarly, we would need another parameter 'extvbus' which is required by OMAP3EVM Rev >= E. This way the parameter list would keep increasing and would look ugly. So how about passing a "struct musb_board_data" structure completely ? It Can be generic across the musb platforms or we can have it only for OMAP platforms. Ajay > board_smc91x_init(); > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html