Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tony Lindgren <tony@xxxxxxxxxxx> [091229 12:00]:
> * Felipe Balbi <me@xxxxxxxxxxxxxxx> [091229 11:54]:
> > On Tue, 2009-12-29 at 21:53 +0200, Felipe Balbi wrote:
> > > On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote:
> > > > * Felipe Balbi <felipe.balbi@xxxxxxxxx> [091228 03:10]:
> > > > > each board might have a different charge pump and
> > > > > thus able to source more or less current on vbus
> > > > > so let power be easily configurable.
> > > > 
> > > > In order to justify merging this as a fix, can you please update
> > > > the subject and description to describe that this fixes the
> > > > the power value ?
> > > 
> > > for sure, doing it right now.
> > 
> > How about now ? (did the same to the board mode)
> > 
> > commit 860a17d3dc78cc8c640a83ade83dd0ec4f1217f1
> > Author: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> > Date:   Mon Dec 28 00:46:19 2009 +0200
> > 
> >     arm: omap: musb: fix board mode by passing it to usb_musb_init
> >     
> >     each board will have a different mode which is peculiar
> >     to that board.
> >     
> >     Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> > 
> > commit 86b92c438109a95c20fad62804b4b8040f3676b7
> > Author: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> > Date:   Mon Dec 28 00:30:42 2009 +0200
> > 
> >     arm: omap: musb: fix board power budget by passing it to
> > usb_musb_init
> >     
> >     each board might have a different charge pump and
> >     thus able to source more or less current on vbus
> >     so let power be easily configurable.
> >     
> >     Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> 
> Sounds good to me.

Oh one more thing: Can you please repost the series one more
time with LAKML Cc'd? We should have all the arch/arm/*omap*/
patches reviewed there too. Maybe Cc linux-usb too?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux