"Luke-Jr" <luke@xxxxxxxxxx> writes: > On Tuesday 29 December 2009 02:29:22 am Kalle Valo wrote: >> "Luke-Jr" <luke@xxxxxxxxxx> writes: >> > Tested on Nokia N810 in Linux-OMAP tree. Mainline is not bootable yet. >> >> What's the problem in mainline? I haven't tested n8x0 for months :( > > Lack of platform support, as far as I know. Until we have cbus, > there's no way to get the LCD powered... Oh that. I have only used serial console with mainline. Luckily Felipe did some cbus patches, I haven't checked them yet though. >> I think a separate file is not needed, it's not that much code. I >> recommend to just adding it directly to board-n8x0.c. It's simple and >> easier for everyone. > > Seemed simpler to manage in a separate file Having lots of small files is difficult IMHO. > though not as necessary as the LCD stuff (which I also have a patch > against mainline for, but it needs tahvo...) Nice. >> CONFIG_MACH_NOKIA_N8X0_LCD does not look right here. > > Heh, looks like my isolate-and-merge-to-mainline got messed up there. > Of course it should be CONFIG_MACH_NOKIA_N8X0_USB :) Yeah, maybe eating too much ham caused it ;) > Also, scripts/checkpatch.pl gave me a warning about the extern in a .c file, > but I couldn't figure out where else it could reasonably go. Any ideas? :/ Yes, just put everything into one file :) No need for externs then. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
