> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Tuesday, December 22, 2009 5:29 PM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-fbdev- > devel@xxxxxxxxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks > enclosed under DEBUG_FS > > Hi, > > On Thu, 2009-12-17 at 16:18 +0100, ext hvaibhav@xxxxxx wrote: > > From: Vaibhav Hiremath <hvaibhav@xxxxxx> > > > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > Which warning does this fix? I don't get any compiler warnings. > [Hiremath, Vaibhav] Below is the log - CC drivers/video/omap2/dss/core.o drivers/video/omap2/dss/core.c:129: warning: 'core_dump_clocks' defined but not used CC drivers/video/omap2/dss/dss.o > Can you change the name of the patch to a more standard one? > [Hiremath, Vaibhav] Ok, will do that and resubmit. I believe only prefix "OMAP" should do. Thanks, Vaibhav > Tomi > > > --- > > drivers/video/omap2/dss/core.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/video/omap2/dss/core.c > b/drivers/video/omap2/dss/core.c > > index 29497a0..2fabaf2 100644 > > --- a/drivers/video/omap2/dss/core.c > > +++ b/drivers/video/omap2/dss/core.c > > @@ -124,6 +124,7 @@ static void restore_all_ctx(void) > > dss_clk_disable_all_no_ctx(); > > } > > > > +#if defined(CONFIG_DEBUG_FS) && > defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) > > /* CLOCKS */ > > static void core_dump_clocks(struct seq_file *s) > > { > > @@ -149,6 +150,7 @@ static void core_dump_clocks(struct seq_file > *s) > > clocks[i]->usecount); > > } > > } > > +#endif /* defined(CONFIG_DEBUG_FS) && > defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) */ > > > > static int dss_get_clock(struct clk **clock, const char > *clk_name) > > { > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
