> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Tuesday, December 22, 2009 4:44 PM > To: Y, Kishore > Cc: Kevin Hilman; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/3] OMAP: DSS: Low power refresh rate support for dss > > Hi, > > On Tue, 2009-12-22 at 10:37 +0100, ext Y, Kishore wrote: > > These patches add Low Power Refresh functionality for DSS. > > Short info on patches > > > > DSS PM_WKEN to refill DMA > > - DMA request to refill the FIFO will wake up the CORE domain > > DSS2 LPR enable and disable function definition > > - LPR enable and disable functions implementing FIFO merge > > DSS2 sysfs enteries to export LPR enable to user > > - sysfs entries for above methods > > I don't like this approach very much. Fifo merge should be automatic, > not user configurable. It should be integrated into the apply/cache > mechanism in manager.c. > > I actually implemented fifo merge at some point during DSS2 development, > but I had to remove it when changing the driver/device model. I haven't > had time to implement it again, as it not very trivial. The old version > can be found in N900's kernel, and earlier snapshots of DSS2. Can you point me to the git for N900 code or ur old dss code? I couldn't find it. Please suggest: How do we decide when to enable or disable lpr if we include it in manager.c? Should we be doing it based on video pipeline usage...? > > Tomi > ��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
