On Thu, 17 Dec 2009, Paul Walmsley wrote:
> On Wed, 16 Dec 2009, Ranjith Lohithakshan wrote:
>
> > This patch adds clock support for the following AM35xx modules
> > - Ethernet MAC
> > - CAN Controller (HECC)
> > - New MUSB OTG Controller with integrated Phy
> > - Video Processing Front End (VPFE)
> > - Additional UART (UART4)
> >
> > Signed-off-by: Ranjith Lohithakshan <ranjithl@xxxxxx>
> > ---
> > arch/arm/mach-omap2/clock34xx_data.c | 93 +++++++++++++++++++++++++++++++++
> > arch/arm/mach-omap2/cm-regbits-34xx.h | 6 ++
> > 2 files changed, 99 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/clock34xx_data.c b/arch/arm/mach-omap2/clock34xx_data.c
> > index 043caed..d7942b3 100644
> > --- a/arch/arm/mach-omap2/clock34xx_data.c
> > +++ b/arch/arm/mach-omap2/clock34xx_data.c
> > @@ -2983,6 +2983,91 @@ static struct clk wdt1_fck = {
> > .recalc = &followparent_recalc,
> > };
> >
> > +/* Clocks for AM35XX */
> > +static struct clk emac_ick = {
> > + .name = "emac_ick",
> > + .ops = &clkops_omap2_dflt,
>
> Shouldn't this clock use &clkops_omap2_dflt_wait (or rather, some custom
> version that knows how to read the _ACK bits in IPSS_CLK_CTRL) and test
> CPGMAC_VBUSP_CLK_EN_ACK? Same for the other IPSS VBUSP clocks? (I guess
> "VBUSP" is a synonym for "interface"?)
Hmmm. Thinking about this further, I suppose this depends on whether the
modules are initiators or targets. Do you know this?
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
