Re: dadd2bb931a08a4b6b17f9e82d9bbe7bedebbc98 breaks omapfb (old non-dss2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 16, 2009 at 2:21 PM, Tomi Valkeinen
<tomi.valkeinen@xxxxxxxxx> wrote:
> Hi,
>
> On Tue, 2009-12-15 at 17:01 +0100, ext Sergey Lapin wrote:
>> On Tue, Dec 15, 2009 at 6:22 PM, Tomi Valkeinen
>> <tomi.valkeinen@xxxxxxxxx> wrote:
>> > Hi,
>> >
>> > On Tue, 2009-12-15 at 10:58 +0100, ext Sergey Lapin wrote:
>> >> dadd2bb931a08a4b6b17f9e82d9bbe7bedebbc98
>> >> OMAP: OMAPFB: add omapdss device
>> >>
>> >>     The upcoming new display subsystem driver is divided to two devices,
>> >>     omapdss and omapfb, of which omapdss handles the actual hardware.
>> >>
>> >>     This patch adds a dummy omapdss platform device for the current omapfb
>> >>     driver, which is then used to get the clocks. This will make it possible
>> >>     for the current and the new display drivers to co-exist.
>> >>
>> >>     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxx>
>> >>     Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
>> >>
>> >> breaks old omapfb.
>> >
>> > I didn't look at this further, but I quickly tested with OMAP3 SDP
>> > board, reverting the patch that makes SDP use DSS2, and it seems to work
>> > fine with the old omapfb.
>
> rfbi.c was still using omapfb device to get the clocks. Can you try this
> patch?
>
>
> >From 33b78006fb0387e21d5f780338d821621ecad929 Mon Sep 17 00:00:00 2001
> From: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxx>
> Date: Wed, 16 Dec 2009 13:18:07 +0200
> Subject: [PATCH] OMAP: OMAPFB: fix clk_get for RFBI
>
> omapfb platform device was still used to get clocks inside rfbi.c
If you add #include <linux/platform_device.h> to this patch,
then problem is fixed.

>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxx>
Tested-by: Sergey Lapin <slapin@xxxxxxxxxxx>

> ---
>  drivers/video/omap/dispc.c  |    2 +-
>  drivers/video/omap/omapfb.h |    2 ++
>  drivers/video/omap/rfbi.c   |    4 ++--
>  3 files changed, 5 insertions(+), 3 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux