On Wed, 16 Dec 2009 17:16:28 +0100 Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> wrote: > More and more looking at this, I think that omap_mcbsp_request() should be > cleaned up frist in respect of freeing resources on error before we put any > new functionality there. > Good idea. > I'm not sure if it is really required to revert any > mcbsp->pdata->ops->request() or omap34xx_mcbsp_request() applied changes by > calling mcbsp->pdata->ops->free() or omap34xx_mcbsp_free() from here. > It is allways worth/must to keep request and free calls in balance as your patch does. In this case some clocks may left running (omap1_mcbsp_request/_free) or wakeup behavior (34xx) otherwise. Acked-by: Jarkko Nikula <jhnikula@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
