>From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] >Sent: Tuesday, December 15, 2009 12:22 PM > >On Tue, Dec 15, 2009 at 8:19 AM, Omar Ramirez Luna <omar.ramirez@xxxxxx> wrote: >> Avoid calls to read the register if pDevContext is available >> to the function, this will save a call to query and hold >> a semaphore under registry operations. > >[...] > >> --- a/drivers/dsp/bridge/wmd/tiomap3430_pwr.c >> +++ b/drivers/dsp/bridge/wmd/tiomap3430_pwr.c >> @@ -82,11 +82,8 @@ DSP_STATUS handle_constraints_set(struct WMD_DEV_CONTEXT *pDevContext, >> #ifdef CONFIG_BRIDGE_DVFS >> u32 *pConstraintVal; >> DSP_STATUS status = DSP_SOK; >> - struct CFG_HOSTRES resources; > >This breaks the build when DVFS is enabled, because of: >status = HW_MBOX_saveSettings(resources.dwMboxBase); Yes, this was removed in old patches, so patch assumes it is not there. I'll drop from the series for now. > >> struct dspbridge_platform_data *pdata = >> omap_dspbridge_dev->dev.platform_data; >> - status = CFG_GetHostResources( >> - (struct CFG_DEVNODE *)DRV_GetFirstDevExtension(), &resources); >> >> pConstraintVal = (u32 *)(pArgs); >> /* Read the target value requested by DSP */ > >BTW. Nobody is checking for errors in the 'status' variable. Will recheck. - omar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
