On Sun, Dec 6, 2009 at 9:33 PM, jassi brar <jassisinghbrar@xxxxxxxxx> wrote: > setting master->cleanup = NULL shud do > > how about dropping it altogether? > > no need for cleanup callback if u have nothing to do in _close. > > no need of {} > > the status shud default to -EINPROGRESS, not success. > > In remove you might want to wait for mssg queue to be flushed? > All good points. I'll make my corrections and resubmit. Thanks - Cory -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html