> > diff --git a/arch/arm/mach-omap2/pm-debug.c
> b/arch/arm/mach-omap2/pm-debug.c
> > index 767ebbc..3a42615 100644
> > --- a/arch/arm/mach-omap2/pm-debug.c
> > +++ b/arch/arm/mach-omap2/pm-debug.c
> > @@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
> >
> > #else
> > void pm_dbg_update_time(struct powerdomain *pwrdm, int prev) {}
> > +int pm_dbg_regset_init(int reg_set) {}
> > +int pm_dbg_regset_save(int reg_set) {}
>
> you'll get compiler warnings from these.
Can be changed to return with value zero for these API's.
>
> > #endif
>
> but even there, this should be fixed in pm.h. The current PM branch
> has these defines already:
>
> #define pm_dbg_regset_save(reg_set) do {} while (0);
> #define pm_dbg_regset_init(reg_set) do {} while (0);
>
> It would be cleaner to fix the #ifdef there to handle the
> !CONFIG_DEBUG_FS case.
pm branch has else condition for CONFIG_PM_DEBUG. But, CONFIG_DEBUG_FS
is not handled. As there is already similar API - pm_dbg_update_time in
pm_debug.c, these API's can also fit there. More over, using !CONFIG_DEBUG_FS
will add some #ifdef's in header.
-Manjunath--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
