Re: [PATCHv2 1/3] OMAP UART: Add omap-serial driver support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Govindraj.R wrote:
This patch adds support for OMAP3430-HIGH SPEED UART Controller.

Signed-off-by: Govindraj R <govindraj.raja@xxxxxx>

Could you fix these checkpatch errors:

ERROR: need consistent spacing around '|' (ctx:VxW)
#477: FILE: drivers/serial/omap-serial.c:238:
+	} while ((lsr & (UART_LSR_DR| UART_LSR_BI)) && (max_count-- > 0));
 	                            ^

ERROR: space required after that ',' (ctx:VxV)
#1093: FILE: drivers/serial/omap-serial.c:854:
+	serial_out(up, UART_OMAP_WER,0x7f);
 	                            ^

WARNING: suspect code indent for conditional statements (8, 17)
#1719: FILE: drivers/serial/omap-serial.c:1480:
+	if (!uart->context_valid)
+		 return;

total: 2 errors, 1 warnings, 1975 lines checked

Thanks,

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux