> owner@xxxxxxxxxxxxxxx] On Behalf Of Kalle Jokiniemi
> Sent: Tuesday, October 27, 2009 5:14 PM
>
> Hi Nishanth,
>
> Found some dead code, see below:
[...]
> > +/* T2 SMART REFLEX */
> > +#define R_SRI2C_SLAVE_ADDR 0x12
> > +#define R_VDD1_SR_CONTROL 0x00
> > +#define R_VDD2_SR_CONTROL 0x01
> > +
> > +/* VDDs*/
> > +#define PRCM_VDD1 1
> > +#define PRCM_VDD2 2
> > +
>
> This comment below can be removed, provided that you apply my other
> comments.
>
> > +/*
> > + * XXX: These should be removed/moved from here once we have a working
> DVFS
> > + * implementation in place
> > + */
> > +#define PHY_TO_OFF_PM_MASTER(p) (p - 0x36)
>
> No need for PHY_TO_OFF_PM_MASTER definition. Remove that.
>
>
> > +#define PHY_TO_OFF_PM_RECIEVER(p) (p - 0x5b)
> > +#define PHY_TO_OFF_PM_INT(p) (p - 0x2e)
>
> No need for PHY_TO_OFF_PM_INT def. Remove.
>
> > +
> > +/* Vmode control */
> > +#define R_DCDC_GLOBAL_CFG PHY_TO_OFF_PM_RECIEVER(0x61)
> > +/* R_DCDC_GLOBAL_CFG register, SMARTREFLEX_ENABLE values */
> > +#define DCDC_GLOBAL_CFG_ENABLE_SRFLX 0x08
>
>
> As we now have other ways of determining opp, remove code from here...
>
> > +
> > +/* DEVICE ID/DPLL ID/CLOCK ID: bits 28-31 for OMAP type */
> > +#define OMAP_TYPE_SHIFT 28
> > +#define OMAP_TYPE_MASK 0xF
> > +/* OPP ID: bits: 0-4 for OPP number */
> > +#define OPP_NO_POS 0
> > +#define OPP_NO_MASK 0x1F
> > +/* OPP ID: bits: 5-6 for VDD */
> > +#define VDD_NO_POS 5
> > +#define VDD_NO_MASK 0x3
> > +/* Other IDs: bits 20-27 for ID type */
> > +/* These IDs have bits 25,26,27 as 1 */
> > +#define OTHER_ID_TYPE_SHIFT 20
> > +#define OTHER_ID_TYPE_MASK 0xFF
> > +
> > +#define OTHER_ID_TYPE(X) ((X & OTHER_ID_TYPE_MASK) <<
> OTHER_ID_TYPE_SHIFT)
> > +#define ID_OPP_NO(X) ((X & OPP_NO_MASK) << OPP_NO_POS)
> > +#define ID_VDD(X) ((X & VDD_NO_MASK) << VDD_NO_POS)
> > +#define OMAP(X) ((X >> OMAP_TYPE_SHIFT) &
> OMAP_TYPE_MASK)
> > +#define get_opp_no(X) ((X >> OPP_NO_POS) & OPP_NO_MASK)
> > +#define get_vdd(X) ((X >> VDD_NO_POS) & VDD_NO_MASK)
> > +
> > +/* XXX: end remove/move */
> > +
> > +/* XXX: find more appropriate place for these once DVFS is in place */
> > +extern u32 current_vdd1_opp;
> > +extern u32 current_vdd2_opp;
>
> ...to here.
>
> At least with a quick glance, it seems the above defs are not in use.
> Your compiler should tell if I missed something ;)
Thanks... will fix in my rev 5.
Regards,
Nishanth Menon
��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
