Venkatraman S <svenkatr@xxxxxx> writes:
> On Fri, Oct 23, 2009 at 4:39 AM, Kevin Hilman
> <khilman@xxxxxxxxxxxxxxxxxxx> wrote:
>> From: Tero Kristo <tero.kristo@xxxxxxxxx>
>>
>> For HS/EMU devices, these additional features are also used:
>>
>> - DMA interrupt disable routine added
>> - Added DMA controller reset to DMA context restore
>>
>> Signed-off-by: Tero Kristo <tero.kristo@xxxxxxxxx>
>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
[...]
>> +void omap_dma_disable_irq(int lch)
>> +{
>> + u32 val;
>> +
>> + if (cpu_class_is_omap2()) {
>> + /* Disable interrupts */
>> + val = dma_read(IRQENABLE_L0);
>> + val &= ~(1 << lch);
>> + dma_write(val, IRQENABLE_L0);
>> + }
>> +}
>> +
> Just curious - Doesn't it need EXPORT_SYMBOL() ?
No, was not meant to be used by modules. In fact, when I update this
patch for the chmod problem, I'm going to drop the EXPORT_SYMBOL() for
the context save/restore as well since that is only meant to be called
from the PM core.
> Is this used somewhere ? If yes,
> would be nice to have omap_dma_enable_irq as well
Looking closer, it looks like the user of this was removed in
"[PATCH v2 17/32] OMAP3: PM: Fix secure SRAM context save/restore", so I'll
remove this function in that patch as well.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
