Amit, <snip> > -----Original Message----- > From: Amit Kucheria [mailto:amit.kucheria@xxxxxxxxxxxxx] On Behalf Of Amit > Kucheria > Sent: Thursday, October 01, 2009 6:46 PM > To: Krishnamoorthy, Balaji T > Cc: linux-omap@xxxxxxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; wim@xxxxxxxxx; > timo.t.kokkonen@xxxxxxxxx; ben-linux@xxxxxxxxx; lrg@xxxxxxxxxxxxxxx; > broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx; p_gortmaker@xxxxxxxxx; > a.zummo@xxxxxxxxxxxx; Nayak, Rajendra; Shilimkar, Santosh > Subject: Re: [PATCH v3 01/04] OMAP4: PMIC: Add support for twl6030 irq > framework > > > + > > + status = request_irq(irq_num, handle_twl6030_pih, IRQF_DISABLED, > > + "TWL6030-PIH", &irq_event); > > There is no need for the kthread hack anymore now that threaded irqs are > available to everyone (2.6.32-rc1) > > So above would become, > status = request_threaded_irq(irq_num, handle_twl6030_pih, > twl6030_irq_thread, IRQF_DISABLED, > "TWL6030-PIH", &irq_event); > where, > handle_twl6030_pih is the hard irq handler that mask the interrupt > twl6030_irq_thread is a sleeping call called by the irq framework > > You might also be able to do away with handle_twl6030_pih entirely and > pass > NULL. That along with a IRQF_ONESHOT flag the the request_threaded_irq > routine should automatically mask the irq until the sleeping call returns. > > I am working on doing this to the twl4030 driver currently, if anybody > else > isn't. This is interesting and can improve the TWL framework. Keep us posted about your testing on TWL4030. Thanks !! Regards Santosh ��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
