RE: [PATCH v3 01/04] ARM: OMAP: Rename twl4030* driver files to enable re-use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, Oct 01, 2009 at 05:46:49PM +0530, balajitk@xxxxxx wrote:
> 
> > The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030
> > for OMAP3. The common modules like RTC, Regulator creates opportunity
> > to re-use the most of the code from twl4030.
> 
> > This patch renames few common drivers twl4030* files to twl* to enable
> > the code re-use.
> 
> >  sound/soc/codecs/twl4030.c                         |    2 +-
> 
> Nack on this part of the change.
> 
> The TWL6030 audio architecture is noticably different to the TWL4030
> audio architecture, most of the digital functionality has been moved
> into the OMAP and the I2S/DSP DAIs replaced by PDM links.  Merging the
> two drivers was previously suggested in response to the TWL6030 CODEC
> driver postings but Misael Lopez Cruz (who is doing the driver) wasn't
> happy with the idea.

I agree that TWL6030 codec will very different from TWL4030 codec and two 
separate drivers will exist for twl4030 and twl6030.c
The patch which is posted now will make both codec to use the same i2c read
/write api like twl_i2c_write_u8, twl_i2c_read_u8 ...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux