On Wed, Sep 30, 2009 at 11:10 AM, Kevin Hilman
<khilman@xxxxxxxxxxxxxxxxxxx> wrote:
> "Premi, Sanjeev" <premi@xxxxxx> writes:
>
>> Hi all,
>>
>> There is no generic function to translate an OPP to FREQ and vice versa.
>> Came across the problem while trying to submit a follow-up to earlier
>> patch for change in mpurate via bootargs.
>>
>> The function get_opp in resource34xx.c, but it is always called with an
>> explicit addition of MAX_VDDn_OPP e.g.
>>
>> opp = get_opp(mpu_opps + MAX_VDD1_OPP, clk->rate);
>> opp = get_opp(l3_opps + MAX_VDD2_OPP, clk->rate);
>>
>> This is 'addition' is required as there is no encapsulation of the
>> MIN and MAX VDDs associated to the table.
>>
>> The patch below fixes this issue; buy creating a 'table' object with
>> necessary information. It can also help in getting rid of the
>> empty {0, 0, 0} at index 0 of each OPP table.
>>
>> At the moment, it does not break any functionality in resource34xx.c;
>> migration to this encapsulation can be taken as next step.
>>
>> This code is bare 'git-diff' for early comments. Formal patch to follow...
>
> Looks ok. Please send updated patch against current PM branch.
oops, please ignore. I see you already posted a patch. Will comment there.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
